[WIP] Enabling nested spans for trace mode OpenTelemetry #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandreeva-nv
requested review from
Tabrizian,
GuanLuo,
tanmayv25,
nnshah1 and
rmccorm4
and removed request for
Tabrizian
rmccorm4
reviewed
Jun 12, 2023
| @@ -50,6 +50,12 @@ | |||
| #include "triton/common/triton_json.h" | |||
| #include "tritonserver_apis.h" | |||
|
|
|||
| #ifndef _WIN32 | |||
| #include "opentelemetry/sdk/trace/tracer.h" | |||
| namespace otel_trace_api = opentelemetry::trace; | |||
There was a problem hiding this comment.
@oandreeva-nv in your screenshot examples, why are they labeled "unknown_service"? Is there some label we can put in the source to have these say "Triton" or something in the collector/UI view if there is no label already set?
(i.e. if supporting passing existing span/context in the future, maybe that would have some label associated with it, I'm not sure how those APIs look)
There was a problem hiding this comment.
It's due to the jaeger. I was planning to investigate if we can do something with this on our side, or if it is something, that need to be addressed on the collector's side
oandreeva-nv
changed the title
|
Working on the doc for discussions |
|
Closing: moved this logic to server side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables nested spans for trace mode OpenTelemetry. Major changes are:
cclang, so it has a lot ofcclangrelated changesCurrent logic : on the core side I create 2 spans: Request span, which has the same name as the model, this request is sent to, and compute span, which holds compute related timestamps and events and represents the amount of time compute took:
How it looks:
Note: this PR should be merged with server's PR: triton-inference-server/server#5928