Revision 1

triton-inference-server · Jul 27, 2023 · e986006 · e986006
1 parent 2ea04df
commit e986006
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/include/triton/core/tritonserver.h b/include/triton/core/tritonserver.h
@@ -879,7 +879,10 @@ TRITONSERVER_DECLSPEC struct TRITONSERVER_Error*
 TRITONSERVER_InferenceTraceRequestId(
     struct TRITONSERVER_InferenceTrace* trace, const char** request_id);
 
-/// Get the child trace, spawned from the parent trace.
+/// Get the child trace, spawned from the parent trace. The caller owns
+/// the returned object and must call TRITONSERVER_InferenceTraceDelete
+/// to release the object, unless ownership is transferred through
+/// other APIs (see TRITONSERVER_ServerInferAsync).
 ///
 /// \param trace The trace.
 /// \param child_trace Returns the child trace, spawned from the trace.

diff --git a/src/tritonserver.cc b/src/tritonserver.cc
@@ -1067,8 +1067,12 @@ TRITONSERVER_InferenceTraceSpawnChildTrace(
 {
 #ifdef TRITON_ENABLE_TRACING
   tc::InferenceTrace* ltrace = reinterpret_cast<tc::InferenceTrace*>(trace);
-  *child_trace =
-      reinterpret_cast<TRITONSERVER_InferenceTrace*>(ltrace->SpawnChildTrace());
+  if (trace != nullptr) {
+    *child_trace = reinterpret_cast<TRITONSERVER_InferenceTrace*>(
+        ltrace->SpawnChildTrace());
+  } else {
+    *child_trace = nullptr;
+  }
   return nullptr;  // Success
 #else
   return TRITONSERVER_ErrorNew(