Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piotrm request client #707

Open
wants to merge 4 commits into
base: imant-dummy-client
Choose a base branch
from

Fix CodeQL error for Exception and Client

c3136ef
Select commit
Loading
Failed to load commit list.
Open

Piotrm request client #707

Fix CodeQL error for Exception and Client
c3136ef
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Jun 17, 2024 in 4s

23 new alerts including 1 error

New alerts in code changed by this pull request

  • 1 error
  • 3 warnings
  • 19 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 82 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable '_DEFAULT_FUTURES_INIT_TIMEOUT_S' is not used.

Check warning on line 266 in src/python/library/tritonclient/hl/lw/http.py

See this annotation in the file changed.

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'close' is unnecessary as it is
redefined
Loading
before this value is used.

Check warning on line 191 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

`__init__` method calls overridden method Warning

Call to self.
_handle_lazy_init
Loading
in __init__ method, which is overridden by
method ModelClient._handle_lazy_init
Loading
.

Check notice on line 35 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'asyncio' is not used.

Check notice on line 36 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'contextlib' is not used.

Check notice on line 42 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Future' is not used.

Check notice on line 43 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Full' is not used.

Check notice on line 44 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Thread' is not used.

Check notice on line 59 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'PyTritonClientQueueFullError' is not used.

Check notice on line 30 in src/python/library/tritonclient/hl/lw/grpc.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'InferResponse' is not used.

Check notice on line 319 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check warning on line 301 in src/python/library/tritonclient/hl/lw/infer_input.py

See this annotation in the file changed.

Code scanning / CodeQL

Unreachable code Warning

This statement is unreachable.

Check notice on line 750 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 769 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 875 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 59 in src/python/library/tritonclient/hl/model_config/parser.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 212 in src/python/library/tritonclient/hl/utils.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

Check notice on line 45 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'Any' is not used.

Check notice on line 21 in src/python/library/tritonclient/hl/lw/http.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'InferInput' is not used.

Check notice on line 16 in src/python/library/tritonclient/hl/lw/infer_input.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'requests' is not used.

Check notice on line 116 in src/python/library/tritonclient/_client.py

See this annotation in the file changed.

Code scanning / CodeQL

Should use a 'with' statement Note

Instance of context-manager class
ModelClient
Loading
is closed in a finally block. Consider using 'with' statement.

Check notice on line 915 in src/python/library/tritonclient/hl/client.py

See this annotation in the file changed.

Code scanning / CodeQL

Unnecessary lambda Note

This 'lambda' is just a simple wrapper around a callable object. Use that object directly.

Check failure on line 262 in src/python/library/tritonclient/hl/lw/http.py

See this annotation in the file changed.

Code scanning / CodeQL

Illegal raise Error

Illegal class 'NoneType' raised; will result in a TypeError being raised instead.