Only add to window if window exists

[SamSamskies]

This prevents window is not defined error when using SSR frameworks such as Next.js.

Sample Next.js app that demonstrates error when trying to import suggestions module: https://github.com/SamSamskies/suggestions-demo

Screenshot of error:

[utb2017]

how do i "npm install suggestions" with this pull request? next js deployment installs the version without this change and errors out my build

[SamSamskies]

how do i "npm install suggestions" with this pull request? next js deployment installs the version without this change and errors out my build

That's actually exactly why I made this PR. I think you can import this library using Next.js dynamic imports to get around the issue for now. https://nextjs.org/docs/advanced-features/dynamic-import#with-no-ssr.

You could also fork this repo and merge this PR in your fork and use your forked version. Last release for this library was 13 months ago, so I'm not sure if it's being maintained anymore.

[utb2017]

I could not get around the issue with the dynamic import (works on dev, but vercel rebuilds the node_modules folder based on package.json). The vercel builder still throws an error on deployment. I was able to deploy my website through firebase hosting though. Here is a link to a simple deployment method if you are a firebase user. NextJS and Firebase Hosting

Use firebase deploy --only hosting at the end of this video.

[SamSamskies]

I could not get around the issue with the dynamic import (works on dev, but vercel rebuilds the node_modules folder based on package.json)

What do you mean by this? You shouldn't be editing the files inside of the node_modules folder. The only time I'd do this is when trying to debug issues with dependencies.

Specifying { ssr: false } as an option to your dynamic import should get around the window is not defined issue because then the import will only execute in the browser.

[tristen]

Thanks for the PR!

[tristen]

Published v1.7.1