Enable usage of tab to focus next element after selection #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds fair to me. |
andrewharvey
approved these changes
Mar 6, 2019
|
👍 |
This was referenced Mar 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current behavior I find that it's impossible to escape the input field using keyboard navigation only. This is because of
e.preventDefault()in the handler for TAB and ENTER key events.In this PR a check is introduced to determine if the suggestion list is open or not. If it's open, TAB can be used to select an item in the list. If it's not open, the standard browser behavior is used to move focus to the next focusable element on the page.
I needed to implement this quick-fix at work in order to enable full keyboard navigation on the page where the suggestion component will be used. Feel free to decline the PR if it introduces any unwanted behavior which does not align well with your idea of how it's supposed to work.