Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 11879: VASP Modal Tab navigation refactoring #965

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

masskoder
Copy link
Collaborator

Scope of changes

This improve and fix definitely the issue about tab navigation

Type of change

  • bug fix
  • new feature
  • documentation
  • other (improve)

Acceptance criteria

https://app.shortcut.com/rotational/story/11879/allow-navigating-with-tab-between-input-fields

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@masskoder masskoder requested a review from elysee15 December 22, 2022 20:18
@masskoder masskoder changed the title Sc 11879/refactor Sc 11879: VASP Modal Tab navigation refactoring Dec 22, 2022
@masskoder masskoder merged commit 0fcdb80 into main Dec 22, 2022
@masskoder masskoder deleted the sc-11879/refactor branch December 22, 2022 21:12
DanielSollis pushed a commit that referenced this pull request Mar 30, 2023
* refact: improve transparentbackground

* test: update test implementation

* refactor: improve choose organization component

* style: add overflow to vasp list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants