Remove deprecation warnings from Github Actions #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeziel
reviewed
Dec 12, 2022
| echo "::set-output name=tag::${GITHUB_REF#refs/*/}" | ||
| echo "::set-output name=revision::$(git rev-parse --short HEAD)" | ||
| echo "tag=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT | ||
| echo "revision=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Are we missing something? I'm still seeing some set-output warnings in the CI: https://github.com/trisacrypto/directory/actions/runs/3680285547
There was a problem hiding this comment.
It looks like those deprecation warnings are bubbling up from some of our dependencies; once they have updated their actions as we have done in this PR, they should hopefully all go away. It might require us to update some of the action versions pinned in our yaml files.
…ns published on the marketplace
…ry into deprecation-warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This PR attempts to address the deprecation warnings related to the set-output workflow in Github Actions, which I believe Ensign is using to determine the commit and branch is being shown in the front end. I've used the instructions posted by Github here. Fixes SC-10218
Type of change
Acceptance criteria
If this works, the deprecations warnings in Github Actions should go away (at least the ones related to
set-output😄 )Author checklist
Reviewer(s) checklist