-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFF Utility for Organization Management #937
Conversation
Codecov ReportBase: 43.99% // Head: 43.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
- Coverage 43.99% 43.93% -0.07%
==========================================
Files 688 688
Lines 25573 25609 +36
Branches 1562 1565 +3
==========================================
- Hits 11252 11251 -1
- Misses 12874 12911 +37
Partials 1447 1447
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a90bb1c
to
e292a30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and thanks for doing the extra GDS work to get the command working. I just had a few questions about some edge cases in addCollab before I mark it as approved.
if err = db.UpdateOrganization(curOrg); err != nil { | ||
return cli.Exit(fmt.Errorf("could not update user's current organization: %w", err), 1) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to make sure the user does not maintain their role if they are a leader in their "default" organization and they are moved to an organization where they shouldn't be a leader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managing roles is a little annoying -- in the first pass at this, the manual trigger will be used for users that have the TSP role, so changing the role isn't too important, and if it is we can do it in auth0. I'm hopeful that the collaborators management feature will come online before we have to really use bffutil
in earnest -- but we could create a future story for roles if we think we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, just wanted to make sure we thought of that; since we are primarily using this for TSPs I'm 100% okay with not attempting to change roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, the logic looks good to me now.
Scope of changes
Adds a
bffutil
CLI program that will help us manually manage organizations in order to get CipherTrace TSP users access to old/previous organizations and for us to manage all organizations in the BFF.TODO:
Fixes SC-11778
Type of change
Acceptance criteria
leveldb
store namespace issue?bffutil
command to the bff Dockerfile?bffutil
on the pod?Author checklist
Reviewer(s) checklist
bffutil
deployment