Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user endpoint #933

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Update user endpoint #933

merged 3 commits into from
Dec 5, 2022

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Dec 2, 2022

Scope of changes

This adds an endpoint to update the user's profile. Currently this only supports updating the user's name.

SC-11445

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

}

// Commit the update to Auth0
if err = s.auth0.User.Update(*user.ID, patch); err != nil {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test if this works for users who have signed up using an external identity service (e.g. google)

@daniellemaxwell daniellemaxwell self-requested a review December 5, 2022 17:09
Copy link
Collaborator

@daniellemaxwell daniellemaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pdeziel pdeziel merged commit 6bfc60a into main Dec 5, 2022
@pdeziel pdeziel deleted the sc-11445 branch December 5, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants