Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc-11626: minor fixes & clean up #925

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Sc-11626: minor fixes & clean up #925

merged 5 commits into from
Dec 1, 2022

Conversation

masskoder
Copy link
Collaborator

Scope of changes

Sc-11626: minor fixes & clean up

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 43.94% // Head: 43.96% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7b3b585) compared to base (805889f).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   43.94%   43.96%   +0.01%     
==========================================
  Files         687      687              
  Lines       25461    25453       -8     
  Branches     1552     1552              
==========================================
  Hits        11190    11190              
+ Misses      12836    12828       -8     
  Partials     1435     1435              
Flag Coverage Δ
unittests 43.96% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/AddNewVaspModal/AddNewVaspModal.tsx 52.63% <ø> (+2.63%) ⬆️
...borators/EditCollaborator/useUpdateCollaborator.ts 0.00% <0.00%> (ø)
web/gds-user-ui/src/hooks/useAuth.ts 42.85% <ø> (+1.19%) ⬆️
...b/gds-user-ui/src/modules/auth/login/user.slice.ts 15.06% <ø> (+0.20%) ⬆️
...src/modules/dashboard/certificate/registration.tsx 0.00% <ø> (ø)
...ules/dashboard/collaborator/CollaboratorService.ts 50.00% <ø> (+3.84%) ⬆️
...ules/dashboard/organization/SwitchOrganization.tsx 3.03% <0.00%> (+0.17%) ⬆️
web/gds-user-ui/src/hooks/useQuery.ts 87.50% <87.50%> (-12.50%) ⬇️
web/gds-user-ui/src/modules/verify/index.tsx 55.55% <100.00%> (-3.42%) ⬇️
web/gds-user-ui/src/utils/permission.ts 62.50% <100.00%> (-2.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit 8e3783d into main Dec 1, 2022
@masskoder masskoder deleted the sc-11626/clean-up branch December 1, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants