Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-11501 Refactor the add new managed modal #919

Merged
merged 2 commits into from
Nov 29, 2022
Merged

sc-11501 Refactor the add new managed modal #919

merged 2 commits into from
Nov 29, 2022

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Nov 29, 2022

Scope of changes

sc-11501 Refactor the add new managed modal

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/11501/refactor-the-add-new-managed-modal
image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested a review from masskoder November 29, 2022 16:29
@masskoder masskoder merged commit 69823bf into main Nov 29, 2022
@masskoder masskoder deleted the fix/sc-11501 branch November 29, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants