Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-10544 Add New managed VASP on user ui #908

Merged
merged 2 commits into from
Nov 25, 2022
Merged

sc-10544 Add New managed VASP on user ui #908

merged 2 commits into from
Nov 25, 2022

Conversation

elysee15
Copy link
Contributor

Scope of changes

sc-10544 Add New managed VASP on user ui

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/10544/add-new-managed-vasp-on-user-ui

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested a review from masskoder November 22, 2022 21:09
@codecov-commenter
Copy link

Codecov Report

Base: 44.57% // Head: 44.60% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1d6bfec) compared to base (26d9e82).
Patch coverage: 7.14% of modified lines in pull request are covered.

❗ Current head 1d6bfec differs from pull request most recent head 5e50427. Consider uploading reports for the commit 5e50427 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   44.57%   44.60%   +0.03%     
==========================================
  Files         673      670       -3     
  Lines       24338    24317      -21     
  Branches     1523     1517       -6     
==========================================
- Hits        10848    10847       -1     
+ Misses      12104    12085      -19     
+ Partials     1386     1385       -1     
Flag Coverage Δ
unittests 44.60% <7.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/gds-user-ui/src/application/routes/routes.ts 80.00% <ø> (ø)
...onents/ChooseAnAccount/ChooseAnAccount.stories.tsx 0.00% <0.00%> (ø)
...s-user-ui/src/components/ChooseAnAccount/index.tsx 20.00% <0.00%> (+20.00%) ⬆️
...b/gds-user-ui/src/components/Sidebar/MobileNav.tsx 6.25% <0.00%> (-0.42%) ⬇️
...ules/dashboard/organization/organizationService.ts 33.33% <0.00%> (+33.33%) ⬆️
web/gds-user-ui/src/components/Account/index.tsx 100.00% <100.00%> (ø)
...ds-user-ui/src/modules/dashboard/profile/index.tsx 0.00% <0.00%> (-33.34%) ⬇️
web/gds-user-ui/src/utils/utils.ts 40.32% <0.00%> (-2.54%) ⬇️
...b/gds-user-ui/src/modules/auth/login/user.slice.ts 13.88% <0.00%> (-2.06%) ⬇️
...com/trisacrypto/directory/pkg/gds/certman/certs.go 54.91% <0.00%> (-0.32%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit 9d4ccad into main Nov 25, 2022
@masskoder masskoder deleted the sc-10544 branch November 25, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants