Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trtl metrics investigation #904

Merged
merged 2 commits into from
Nov 22, 2022
Merged

trtl metrics investigation #904

merged 2 commits into from
Nov 22, 2022

Conversation

bbengfort
Copy link
Collaborator

Scope of changes

Adds a command to trtl to scrape the metrics of database usage from the client side.

Fixes SC-11372

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

@bbengfort bbengfort requested a review from pdeziel November 21, 2022 22:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Base: 44.66% // Head: 44.66% // No change to project coverage 👍

Coverage data is based on head (a26c712) compared to base (aafe412).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   44.66%   44.66%           
=======================================
  Files         667      667           
  Lines       24198    24198           
  Branches     1517     1517           
=======================================
  Hits        10807    10807           
  Misses      12017    12017           
  Partials     1374     1374           
Flag Coverage Δ
unittests 44.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will definitely be a helpful tool. The only thing I can think of is if we need to include the index namespaces as well.

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
KUBECTX="$(kubectl config current-context)"

echo "your k8s cluster context is $KUBECTX"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good message!

@bbengfort bbengfort merged commit fb8b5d4 into main Nov 22, 2022
@bbengfort bbengfort deleted the sc-11372/trtl-overview branch November 22, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants