Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-10115 Print view does not work #876

Merged
merged 3 commits into from
Nov 14, 2022
Merged

sc-10115 Print view does not work #876

merged 3 commits into from
Nov 14, 2022

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Nov 9, 2022

Scope of changes

sc-10115 Print view does not work

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/10115/print-view-does-not-work

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested a review from masskoder November 9, 2022 08:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Base: 44.35% // Head: 44.35% // No change to project coverage 👍

Coverage data is based on head (b0a9939) compared to base (8afa28d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   44.35%   44.35%           
=======================================
  Files         638      638           
  Lines       23528    23528           
  Branches     1416     1416           
=======================================
  Hits        10436    10436           
  Misses      11737    11737           
  Partials     1355     1355           
Flag Coverage Δ
unittests 44.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gds-admin-ui/src/pages/app/details/VaspDocument.js 23.52% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elysee15 elysee15 marked this pull request as ready for review November 9, 2022 14:24
@masskoder masskoder merged commit c87cd27 into main Nov 14, 2022
@masskoder masskoder deleted the fix/sc-10115 branch November 14, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants