Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reissaunce timestamp to vasp snippet #871

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Add reissaunce timestamp to vasp snippet #871

merged 2 commits into from
Nov 4, 2022

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Nov 4, 2022

Scope of changes

This adds a reissuance timestamp to the VASP snippet. This is required for the frontend to be able to filter/order VASPs by certificate reissuance date.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@pdeziel pdeziel requested a review from rebeccabilbro November 4, 2022 18:57
@@ -1,6 +1,5 @@
{
"cSpell.words": ["import", "State"],
"editor.defaultFormatter": "esbenp.prettier-vscode",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was breaking the go formatter in the vscode, after discussing with @masskoder we decided to remove it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 43.99% // Head: 44.02% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2e0619d) compared to base (5de05d8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   43.99%   44.02%   +0.03%     
==========================================
  Files         630      630              
  Lines       23154    23155       +1     
  Branches     1416     1416              
==========================================
+ Hits        10187    10195       +8     
+ Misses      11630    11625       -5     
+ Partials     1337     1335       -2     
Flag Coverage Δ
unittests 44.02% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...trisacrypto/directory/pkg/gds/fixtures/fixtures.go 40.57% <0.00%> (ø)
.../github.com/trisacrypto/directory/pkg/gds/admin.go 55.91% <0.00%> (+0.26%) ⬆️
...com/trisacrypto/directory/pkg/gds/secrets/token.go 100.00% <0.00%> (+18.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@rebeccabilbro rebeccabilbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pdeziel, thanks for addressing this quickly to unblock the front end team!

@pdeziel pdeziel merged commit c5bf6f6 into main Nov 4, 2022
@pdeziel pdeziel deleted the sc-10961 branch November 4, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants