Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc-9564: fix form blink issue #867

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Sc-9564: fix form blink issue #867

merged 3 commits into from
Nov 8, 2022

Conversation

masskoder
Copy link
Collaborator

Scope of changes

Initially, I tried refactoring the testnetProgressbar component, but it didn't work, so the simple solution is to increase the timeout during BFF data loading.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/9564/registration-form-blinks

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect the changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@masskoder masskoder requested a review from elysee15 November 3, 2022 14:43
@codecov-commenter
Copy link

Codecov Report

Base: 43.99% // Head: 43.99% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (08b0c25) compared to base (d5cc809).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   43.99%   43.99%   -0.01%     
==========================================
  Files         627      627              
  Lines       23148    23150       +2     
  Branches     1416     1416              
==========================================
  Hits        10184    10184              
- Misses      11628    11630       +2     
  Partials     1336     1336              
Flag Coverage Δ
unittests 43.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ogress/TestNetCertificateProgressBar.component.tsx 0.00% <0.00%> (ø)
...src/modules/dashboard/certificate/registration.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit c9135a1 into main Nov 8, 2022
@masskoder masskoder deleted the sc-9564 branch November 8, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants