Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sc-4309 GDS User UI implement user Profile component #863

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Oct 31, 2022

Scope of changes

feat: sc-4309 GDS User UI implement user Profile component

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/4309/user-profile-component

image

image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested a review from masskoder October 31, 2022 18:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Base: 44.02% // Head: 43.95% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (78c8470) compared to base (5c2468a).
Patch coverage: 13.63% of modified lines in pull request are covered.

❗ Current head 78c8470 differs from pull request most recent head f1b545d. Consider uploading reports for the commit f1b545d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   44.02%   43.95%   -0.07%     
==========================================
  Files         630      632       +2     
  Lines       23155    23168      +13     
  Branches     1416     1416              
==========================================
- Hits        10193    10183      -10     
- Misses      11627    11648      +21     
- Partials     1335     1337       +2     
Flag Coverage Δ
unittests 43.95% <13.63%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/gds-user-ui/src/application/routes/routes.ts 75.00% <ø> (ø)
...b/gds-user-ui/src/components/Sidebar/MobileNav.tsx 6.66% <0.00%> (-0.48%) ⬇️
...b/gds-user-ui/src/components/UserDetails/index.tsx 66.66% <ø> (ø)
...c/components/UserProfile/AddLinkedAccountModal.tsx 0.00% <0.00%> (ø)
...-ui/src/components/UserProfile/ChangeNameModal.tsx 0.00% <0.00%> (ø)
...src/components/UserProfile/ChangePasswordModal.tsx 0.00% <0.00%> (ø)
...omponents/UserProfile/RemoveLinkedAccountModal.tsx 0.00% <0.00%> (ø)
...er-ui/src/components/ui/InputFormControl/index.tsx 87.50% <ø> (ø)
...ds-user-ui/src/modules/dashboard/profile/index.tsx 0.00% <0.00%> (ø)
...b/gds-user-ui/src/components/UserProfile/index.tsx 37.50% <37.50%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elysee15 elysee15 force-pushed the feat/sc-4309 branch 3 times, most recently from 4880cb9 to f9ac037 Compare October 31, 2022 22:04
@elysee15 elysee15 force-pushed the feat/sc-4309 branch 5 times, most recently from 4208443 to 76e5afe Compare November 8, 2022 11:35
@elysee15 elysee15 merged commit 7dddbb7 into main Nov 8, 2022
@elysee15 elysee15 deleted the feat/sc-4309 branch November 8, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants