Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact admin ui #851

Merged
merged 3 commits into from
Oct 31, 2022
Merged

refact admin ui #851

merged 3 commits into from
Oct 31, 2022

Conversation

elysee15
Copy link
Contributor

Scope of changes

refact admin ui

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/10586/refact-admin-ui

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 marked this pull request as ready for review October 28, 2022 01:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 43.93% // Head: 43.92% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (15ad6a1) compared to base (6175047).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   43.93%   43.92%   -0.01%     
==========================================
  Files         625      627       +2     
  Lines       23093    23097       +4     
  Branches     1414     1415       +1     
==========================================
  Hits        10145    10145              
- Misses      11616    11620       +4     
  Partials     1332     1332              
Flag Coverage Δ
unittests 43.92% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pp/details/BasicDetails/dashboard/StatisticCard.js 0.00% <0.00%> (ø)
...s/app/details/BasicDetails/dashboard/Statistics.js 0.00% <0.00%> (ø)
...pages/app/details/BasicDetails/dashboard/Status.js 0.00% <ø> (ø)
.../pages/app/details/BasicDetails/dashboard/Tasks.js 26.08% <ø> (ø)
...s/app/details/BasicDetails/dashboard/TasksChart.js 0.00% <ø> (ø)
.../pages/app/details/BasicDetails/dashboard/index.js 0.00% <ø> (ø)
.../CertificateDetails/IdentityCertificateDropDown.js 100.00% <100.00%> (ø)
.../src/pages/app/details/CertificateDetails/index.js 79.59% <100.00%> (-1.18%) ⬇️
web/gds-admin-ui/src/routes/index.js 92.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit 8f4d4b9 into main Oct 31, 2022
@masskoder masskoder deleted the refact/sc-10586 branch October 31, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants