Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-10115: Fix Print view issue #839

Merged
merged 1 commit into from
Oct 20, 2022
Merged

sc-10115: Fix Print view issue #839

merged 1 commit into from
Oct 20, 2022

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Oct 19, 2022

Scope of changes

sc-10115 Print view does not work

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/10115/print-view-does-not-work

Enregistrement.de.l.ecran.2022-10-19.a.11.31.10.mov

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 44.10% // Head: 44.11% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c287585) compared to base (00aa093).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   44.10%   44.11%   +0.01%     
==========================================
  Files         615      616       +1     
  Lines       23000    23003       +3     
  Branches     1389     1390       +1     
==========================================
+ Hits        10144    10148       +4     
+ Misses      11532    11530       -2     
- Partials     1324     1325       +1     
Flag Coverage Δ
unittests 44.11% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ls/BasicDetails/components/BasicDetailsDropdown.js 50.00% <33.33%> (ø)
...pages/app/details/BasicDetails/components/Print.js 100.00% <100.00%> (ø)
web/gds-admin-ui/src/utils/index.js 45.25% <0.00%> (-0.73%) ⬇️
...com/trisacrypto/directory/pkg/gds/certman/certs.go 55.46% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder changed the title sc-10115 Print view does not work sc-10115: Fix Print view issue Oct 20, 2022
Copy link
Collaborator

@masskoder masskoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. using slugify package is a very good idea 👍

@masskoder masskoder merged commit f2d7763 into main Oct 20, 2022
@masskoder masskoder deleted the fix/sc-10115 branch October 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants