Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-9889 TRISA Guide Page Improvements #833

Merged
merged 2 commits into from
Oct 17, 2022
Merged

sc-9889 TRISA Guide Page Improvements #833

merged 2 commits into from
Oct 17, 2022

Conversation

elysee15
Copy link
Contributor

Scope of changes

sc-9889 TRISA Guide Page Improvements

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/9889/trisa-guide-page-improvements

image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@elysee15 elysee15 requested a review from masskoder October 14, 2022 08:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 31.29% // Head: 44.14% // Increases project coverage by +12.85% 🎉

Coverage data is based on head (e9a0440) compared to base (4a5c3c7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #833       +/-   ##
===========================================
+ Coverage   31.29%   44.14%   +12.85%     
===========================================
  Files         505      613      +108     
  Lines        5620    22965    +17345     
  Branches     1387     1387               
===========================================
+ Hits         1759    10139     +8380     
- Misses       3672    11505     +7833     
- Partials      189     1321     +1132     
Flag Coverage Δ
unittests 44.14% <ø> (+12.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...user-ui/src/components/Section/MembershipGuide.tsx 100.00% <ø> (ø)
web/gds-user-ui/src/layouts/LandingLayout.tsx 81.81% <ø> (ø)
...com/trisacrypto/directory/pkg/trtl/replica/sync.go 7.97% <0.00%> (ø)
....com/trisacrypto/directory/pkg/trtl/interceptor.go 41.48% <0.00%> (ø)
...trisacrypto/directory/pkg/gds/fixtures/fixtures.go 40.57% <0.00%> (ø)
...m/trisacrypto/directory/pkg/gds/admin/v2/decode.go 85.71% <0.00%> (ø)
...om/trisacrypto/directory/pkg/store/trtl/connect.go 0.00% <0.00%> (ø)
...rypto/directory/pkg/bff/models/v1/announcements.go 100.00% <0.00%> (ø)
...ithub.com/trisacrypto/directory/pkg/trtl/backup.go 50.78% <0.00%> (ø)
...om/trisacrypto/directory/pkg/trtl/config/config.go 37.87% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masskoder masskoder merged commit 0a335fb into main Oct 17, 2022
@masskoder masskoder deleted the sc-9889 branch October 17, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants