Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-9903 Add new GDS logo to Nav Menu #826

Merged
merged 1 commit into from
Oct 17, 2022
Merged

sc-9903 Add new GDS logo to Nav Menu #826

merged 1 commit into from
Oct 17, 2022

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Oct 12, 2022

Scope of changes

sc-9903 Add new GDS logo to Nav Menu

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/9903/add-new-gds-logo-to-nav-menu

image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 44.10% // Head: 43.94% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (0a7f0ed) compared to base (2548d38).
Patch has no changes to coverable lines.

❗ Current head 0a7f0ed differs from pull request most recent head 77d1029. Consider uploading reports for the commit 77d1029 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   44.10%   43.94%   -0.16%     
==========================================
  Files         615      612       -3     
  Lines       23000    22792     -208     
  Branches     1389     1385       -4     
==========================================
- Hits        10145    10017     -128     
+ Misses      11531    11470      -61     
+ Partials     1324     1305      -19     
Flag Coverage Δ
unittests 43.94% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ds-user-ui/src/components/Header/LandingHeader.tsx 73.33% <ø> (ø)
...-user-ui/src/components/Sidebar/SidebarContent.tsx 7.14% <ø> (ø)
web/gds-user-ui/src/components/ui/Logo.tsx 100.00% <ø> (ø)
...crypto/directory/pkg/bff/models/v1/collaborator.go 0.00% <0.00%> (-84.22%) ⬇️
...crypto/directory/pkg/bff/models/v1/organization.go 71.54% <0.00%> (-12.27%) ⬇️
...components/CertificateManagement/X509TableRows.tsx 42.85% <0.00%> (-7.15%) ⬇️
...tificateManagement/SealingCertificateTableRows.tsx 42.85% <0.00%> (-7.15%) ⬇️
.../github.com/trisacrypto/directory/pkg/bff/users.go 4.83% <0.00%> (-5.65%) ⬇️
...com/trisacrypto/directory/pkg/bff/api/v1/client.go 48.96% <0.00%> (-1.45%) ⬇️
...s/CertificateReview/LegalPersonReviewDataTable.tsx 30.00% <0.00%> (-1.25%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elysee15 elysee15 force-pushed the sc-9903 branch 2 times, most recently from 1aa3707 to 0a7f0ed Compare October 12, 2022 19:46
Copy link
Collaborator

@masskoder masskoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elysee15 would you mind adding the white logo in the sidebar instead of the black one?

@masskoder masskoder merged commit 00aa093 into main Oct 17, 2022
@masskoder masskoder deleted the sc-9903 branch October 17, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants