Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-9617: Redirect to guide page #815

Merged
merged 2 commits into from
Sep 28, 2022
Merged

sc-9617: Redirect to guide page #815

merged 2 commits into from
Sep 28, 2022

Conversation

masskoder
Copy link
Collaborator

Scope of changes

Redirect /certificate/registration to /guide

Type of change

  • bug fix
  • new feature
  • documentation
  • other (improvement)

Acceptance criteria

https://app.shortcut.com/rotational/story/9617/redirect-certificate-registration-to-guide

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@masskoder masskoder changed the title sc-9617: Redirect /certificate/registration to /guide sc-9617: Redirect to guide page Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 44.00% // Head: 43.99% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5730423) compared to base (1234d99).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   44.00%   43.99%   -0.01%     
==========================================
  Files         613      613              
  Lines       22736    22734       -2     
  Branches     1372     1372              
==========================================
- Hits        10004    10002       -2     
  Misses      11432    11432              
  Partials     1300     1300              
Flag Coverage Δ
unittests 43.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/gds-user-ui/src/application/routes/index.tsx 6.25% <ø> (ø)
web/gds-user-ui/src/application/routes/routes.ts 75.00% <ø> (ø)
.../github.com/trisacrypto/directory/pkg/trtl/trtl.go 78.11% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@daniellemaxwell daniellemaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@masskoder masskoder merged commit 71cfd73 into main Sep 28, 2022
@masskoder masskoder deleted the sc-9617 branch September 28, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants