Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test Workflow #772

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Update Test Workflow #772

merged 7 commits into from
Sep 9, 2022

Conversation

bbengfort
Copy link
Collaborator

Scope of changes

Updates the test workflows which will hopefully improve test times and ensure that CodeCov doesn't take forever.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

I'll merge this if everything looks ok, no need for review.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • N/A

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #772 (72ab1e8) into main (1590759) will increase coverage by 1.13%.
The diff coverage is n/a.

❗ Current head 72ab1e8 differs from pull request most recent head 2e0addf. Consider uploading reports for the commit 2e0addf to get more accurate results

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   43.73%   44.86%   +1.13%     
==========================================
  Files         587      432     -155     
  Lines       18286    19850    +1564     
  Branches     1328      712     -616     
==========================================
+ Hits         7997     8906     +909     
- Misses       9011     9843     +832     
+ Partials     1278     1101     -177     
Flag Coverage Δ
unittests 44.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sacrypto/directory/pkg/gds/models/v1/pagination.go 40.00% <0.00%> (-10.00%) ⬇️
...sacrypto/directory/pkg/trtl/internal/pagination.go 40.00% <0.00%> (-10.00%) ⬇️
...sacrypto/directory/pkg/gds/store/index/sequence.go 72.72% <0.00%> (-7.28%) ⬇️
...crypto/directory/pkg/gds/store/leveldb/iterator.go 48.68% <0.00%> (-6.71%) ⬇️
...b.com/trisacrypto/directory/pkg/utils/wire/wire.go 58.18% <0.00%> (-6.27%) ⬇️
...risacrypto/directory/pkg/bff/api/v1/credentials.go 49.05% <0.00%> (-5.95%) ⬇️
...om/trisacrypto/directory/pkg/gds/emails/bindata.go 53.98% <0.00%> (-5.56%) ⬇️
...c/github.com/trisacrypto/directory/pkg/gds/mock.go 73.33% <0.00%> (-4.89%) ⬇️
.../trisacrypto/directory/pkg/bff/db/organizations.go 61.90% <0.00%> (-4.77%) ⬇️
...com/trisacrypto/directory/pkg/gds/emails/emails.go 73.23% <0.00%> (-4.70%) ⬇️
... and 248 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bbengfort bbengfort merged commit d8658ae into main Sep 9, 2022
@bbengfort bbengfort deleted the update-go-tests branch September 9, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants