Consolidate C9 validation error ignores #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This fixes a compatibility issue with older VASP records. This problem manifests in an error on the Admin UI while trying to update a contact. In the contact update endpoint, GDS checks to make sure the entire VASP record including the contact is valid before committing the update and fails if it is not valid. This issue has been previously discussed in #34 and fixed in the TRISA codebase and we had to put a workaround in the GDS registration code.
This PR consolidates the workaround in one spot to avoid duplicated code and make sure that older VASPs that violate this constraint can still be edited from the Admin UI and adds a test to verify the current behavior.
SC-7632
Type of change
Acceptance criteria
This should fix SC-7632 and the admin should be able to edit contacts from the Admin dashboard.
Author checklist
Reviewer(s) checklist