Emit unpopulated registration form fields #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 43.39% 43.54% +0.14%
==========================================
Files 583 583
Lines 17510 17514 +4
Branches 1310 1320 +10
==========================================
+ Hits 7599 7626 +27
+ Misses 8723 8697 -26
- Partials 1188 1191 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rebeccabilbro
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Nice 😄 -- thanks for adding that test coverage also @pdeziel
bbengfort
pushed a commit
that referenced
this pull request
Sep 6, 2022
bbengfort
added a commit
that referenced
this pull request
Sep 6, 2022
bbengfort
pushed a commit
that referenced
this pull request
Sep 6, 2022
masskoder
added a commit
that referenced
this pull request
Sep 6, 2022
* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * Add baggage to CORS allowed headers * BFF test cleanup (#706) * BFF string constants (#708) * Add VASP timestamps to overview response (#740) * version bump v1.5.0-rc.22 * add VASP timestamps to overview response * Emit unpopulated registration form fields (#741) * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix models merge conflicts Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>
elysee15
added a commit
that referenced
this pull request
Sep 22, 2022
* Handle multiple registered directories in BFF * Version bump to v1.5.0 * Certman refactor and automated reissuance (#753) Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * adds slack notifications to Github Actions container build yaml (#755) Co-authored-by: Cletus Razakou <[email protected]> * Allow multiple DNS names in certificate issuance (#701) Co-authored-by: Benjamin Bengfort <[email protected]> * Add baggage to CORS allowed headers * BFF test cleanup (#706) * BFF string constants (#708) * Add VASP timestamps to overview response (#740) * version bump v1.5.0-rc.22 * add VASP timestamps to overview response * Emit unpopulated registration form fields (#741) * sc-8837 Extend Background Color to bottom of Overview page (#754) * sc-8408 Add min/max to date of incorporation field (#743) * Handle multiple registered directories in BFF * sc-8408 Add min/max to date of incorporation field Co-authored-by: Benjamin Bengfort <[email protected]> * sc-8837 Extend Background Color to bottom of Overview page Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Cletus Razakou <[email protected]> * fix models merge conflicts Co-authored-by: Benjamin Bengfort <[email protected]> Co-authored-by: Patrick Deziel <[email protected]> Co-authored-by: kbelita <[email protected]> Co-authored-by: Daniel Sollis <[email protected]> Co-authored-by: elysee15 <[email protected]> Co-authored-by: Rebecca Bilbro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This changes the JSON marshaling for the registration form so that fields that are unpopulated by the BFF are filled with default values. The reason for this change is to allow certain fields (e.g., compliance_threshold) to persist when the frontend saves registration forms to the database via the BFF.
SC-8634
Type of change
Acceptance criteria
When the frontend saves and loads registration forms using the BFF endpoints, the form should now persist 0-valued fields.
Author checklist
Reviewer(s) checklist