Fix Ensign Config Preventing GDS from Running #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbengfort
commented
Nov 19, 2024
| Network Network `split_words:"true"` | ||
| Enabled bool `default:"false"` | ||
| Topic string `required:"false"` | ||
| Network Network `required:"false" validate:"ignore"` |
There was a problem hiding this comment.
This fixes the unknown network error
bbengfort
commented
Nov 19, 2024
| Testing bool `split_words:"true" default:"false"` | ||
| Ensign ensign.Config | ||
| Testing bool `default:"false" ` | ||
| Ensign ensign.Config `validate:"ignore"` |
There was a problem hiding this comment.
This fixes the client id missing error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
The confire library automatically calls a configurations
Validate()method if it implements it in order to process a valid configuration. We did not want the Ensign config to be validated unless the Activity config (which it was a member of) was enabled. Similarly theNetworkfield also had aValidatemethod which is why those two errors were coming up. This PR fixes those problems.Type of change
Acceptance criteria
This PR will be merged without review.
Author checklist