Adds padding above form buttons, fixes scroll behavior #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellemaxwell
commented
Jan 8, 2024
| @@ -6,6 +6,7 @@ body { | |||
| height: '100%'; | |||
| font-family: 'Open sans', sans-serif; | |||
| scroll-behavior: smooth; | |||
| overflow-anchor: none; | |||
There was a problem hiding this comment.
While making updates to the form, I noticed that the page would often scroll to the center of the page instead of the top. This change appears to remove a browser default causing the issue. https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-anchor
bbengfort
approved these changes
Jan 8, 2024
| @@ -147,7 +147,7 @@ const SidebarContent = ({ onClose, ...rest }: SidebarProps) => { | |||
| textAlign={'center'} | |||
| color="white" | |||
| width="100%"> | |||
| <Text>GIT: {appGitVersion || 'N/A'}</Text> | |||
| <Text>REV: {appGitVersion || 'N/A'}</Text> | |||
There was a problem hiding this comment.
Suggested change
| <Text>REV: {appGitVersion || 'N/A'}</Text> | |
| <Text>App: {appGitVersion || 'N/A'}</Text> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
GITwithREVin the sidebar footer.Previouson the review section the page scrolls to the bottom of section 5 which is the TRIXO form. This is the only instance where I noticed this issue persists, but couldn't determine why.)Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/23860311?key=ee7201e8d7325f34abb9ae6fadf5b905
Author checklist
Reviewer(s) checklist