Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc-20439 : Improve Steps Form #1122

Merged
merged 7 commits into from
Aug 26, 2023
Merged

Sc-20439 : Improve Steps Form #1122

merged 7 commits into from
Aug 26, 2023

Conversation

masskoder
Copy link
Collaborator

Scope of changes

In this PR, enhancements have been made to the multi-step workflow, eliminating the necessity for a hard reload to access updated data. Additionally, the clear button now functions seamlessly. Furthermore, improvements have been implemented to the stepper label's behavior when a user imports a file and progresses through each step.

Type of change

  • bug fix
  • new feature
  • documentation
  • improvement

Acceptance criteria

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Copy link
Collaborator

@daniellemaxwell daniellemaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing a JSON file appeared to work as expected on my end. I noticed some inconsistencies with the stepper label and will share a video of what I saw. Thanks for continuing to push on this!

@daniellemaxwell daniellemaxwell merged commit cd48833 into main Aug 26, 2023
@daniellemaxwell daniellemaxwell deleted the sc-20439 branch August 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants