Sc-17544: Clear form refactoring #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onResetModalClose={handleResetClick} | ||
| isOpened={isOpen} | ||
| handleResetForm={handleResetForm} | ||
| resetFormType="basic" |
There was a problem hiding this comment.
Suggested change
| resetFormType="basic" | |
| resetFormType={StepEnum.CONTACTS} |
| </Trans> | ||
| {isResetAllType ? ( | ||
| <Trans> | ||
| Click “Reset” to clear and reset the registration form. All data will be |
There was a problem hiding this comment.
Suggested change
| Click “Reset” to clear and reset the registration form. All data will be | |
| Click "Reset" to clear and | |
| <Text as="span" fontWeight={'bold'}> | |
| {' '} | |
| reset the form{' '} | |
| </Text>{' '}. All data will be |
There was a problem hiding this comment.
| {isResetAllType ? ( | ||
| <Trans> | ||
| Click “Reset” to clear and reset the registration form. All data will be | ||
| deleted and you will be re-directed to the beginning of the form and you will |
There was a problem hiding this comment.
Suggested change
| deleted and you will be re-directed to the beginning of the form and you will | |
| deleted and cleared from the registration form. You may want to export the data first. |
| <Trans> | ||
| Click “Reset” to clear and reset the registration form. All data will be | ||
| deleted and you will be re-directed to the beginning of the form and you will | ||
| be required to restart the registration process |
There was a problem hiding this comment.
Suggested change
| be required to restart the registration process | |
| After clearing, you will be taken to the start of the form. |
There was a problem hiding this comment.
I'm not currently taken to the start of the form after clearing. Will this be added or should the copy be updated?
| @@ -88,9 +92,9 @@ const ConfirmationResetForm = (props: any) => { | |||
| {' '} | |||
| this section{' '} | |||
| </Text>{' '} | |||
| of the registration form. All data will be cleared from only this section of | |||
There was a problem hiding this comment.
These changes were made to the Clear & Reset Section modal, but they should be in the Clear & Reset Form modal.
daniellemaxwell
approved these changes
May 30, 2023
| <Text as="span" fontWeight={'bold'}> | ||
| reset the form. | ||
| </Text>{' '} | ||
| reset the registration form. All data will be deleted and you will be |
There was a problem hiding this comment.
Suggested change
| reset the registration form. All data will be deleted and you will be | |
| All data will be deleted and cleared |
| reset the form. | ||
| </Text>{' '} | ||
| reset the registration form. All data will be deleted and you will be | ||
| re-directed to the beginning of the form and you will be required to restart |
There was a problem hiding this comment.
Suggested change
| re-directed to the beginning of the form and you will be required to restart | |
| from the registration form. You may want to export the data first. |
| </Text>{' '} | ||
| reset the registration form. All data will be deleted and you will be | ||
| re-directed to the beginning of the form and you will be required to restart | ||
| the registration process |
There was a problem hiding this comment.
Suggested change
| the registration process | |
| After clearing you will be taken to the start of the form. |
| {' '} | ||
| this section{' '} | ||
| </Text>{' '} | ||
| of the form. All data will be deleted and cleared from the registration form. |
There was a problem hiding this comment.
Suggested change
| of the form. All data will be deleted and cleared from the registration form. | |
| of the registration form. All data will be cleared from only this section of the registration form. |
There was a problem hiding this comment.
These suggestions should make the Clear & Reset Section match the Figma file.
| this section{' '} | ||
| </Text>{' '} | ||
| of the form. All data will be deleted and cleared from the registration form. | ||
| You may want to export the data first. After clearing, you will be taken to |
There was a problem hiding this comment.
Suggested change
| You may want to export the data first. After clearing, you will be taken to | |
| Other sections of the registration form will not be cleared. |
| </Text>{' '} | ||
| of the form. All data will be deleted and cleared from the registration form. | ||
| You may want to export the data first. After clearing, you will be taken to | ||
| the start of the form. |
There was a problem hiding this comment.
Suggested change
| the start of the form. |
| <ModalOverlay /> | ||
| <ModalContent width={'100%'}> | ||
| <ModalHeader data-testid="confirmation-modal-header" textAlign={'center'}> | ||
| <Trans id="Clear & Reset Registration Form">Clear & Reset Registration Form</Trans> | ||
| {isResetAllType ? ( | ||
| <Trans>Clear & Reset Registration Form</Trans> |
There was a problem hiding this comment.
Suggested change
| <Trans>Clear & Reset Registration Form</Trans> | |
| <Trans>Clear & Reset Form</Trans> |
There was a problem hiding this comment.
This is what I saw before the suggested changes to match the Figma file:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This adds clear form refactoring.
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist
Reviewer(s) checklist