Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-17032: Add pending review to Register endpoint #1013

Merged
merged 4 commits into from
May 15, 2023
Merged

Conversation

DanielSollis
Copy link
Contributor

Scope of changes

Briefly add notes if applicable and include the story ID

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@DanielSollis DanielSollis requested a review from pdeziel May 12, 2023 19:40
Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just had some cosmetic comments to make sure we're documenting things well for the future. Is there a story to update the tests?

pkg/gds/gds.go Outdated Show resolved Hide resolved
pkg/gds/gds.go Outdated Show resolved Hide resolved
pkg/gds/gds.go Outdated Show resolved Hide resolved
@DanielSollis DanielSollis merged commit 1616c3c into main May 15, 2023
@DanielSollis DanielSollis deleted the sc-17032 branch May 15, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants