Sc 14489: contact migration #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeziel
reviewed
May 15, 2023
cmd/gdsutil/main.go
Outdated
| } | ||
| } else { | ||
| modelContact.Vasps = append(modelContact.Vasps, vasp.CommonName) | ||
| modelContact.EmailLog = append(modelContact.EmailLog, vaspContactExtra.EmailLog...) |
There was a problem hiding this comment.
Does this work if vaspContactExtra.EmailLog is nil?
There was a problem hiding this comment.
whoops, I checked and it doesn't, fixed
| if c.Bool("dryrun") { | ||
| fmt.Println("existing vasp contacts:") | ||
| for _, contact := range vaspContacts { | ||
| fmt.Print(contact) |
There was a problem hiding this comment.
Might want to newline separate these or something or just print out the emails space separated because this is probably going to be messy when things get printed out.
| for iter.Next() { | ||
| vaspContact, _ := iter.Value() | ||
| vaspContacts = append(vaspContacts, vaspContact) | ||
| modelContact, AlreadyExists := modelContacts[vaspContact.Email] |
There was a problem hiding this comment.
We may need to make sure the email is normalized before putting it in the map, although if it's coming from the VASP hopefully it will already be.
|
There is a story for Ben in the email verification epic to do the migration using this command. That will need to happen by Friday so we should probably just go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds a new gdsutil command to migrate vasp contacts to the model contacts namespace.
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist
Reviewer(s) checklist