Send keep alive requests to ensure Kudu scanner does not time out #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Nov 13, 2021
| @@ -58,7 +55,7 @@ | |||
| private final List<Type> columnTypes; | |||
| private final KuduTable table; | |||
| private final Map<Integer, Integer> fieldMapping; | |||
| private RowResultIterator nextRows; | |||
| private KuduScannerIterator kuduScannerIterator; | |||
There was a problem hiding this comment.
Can you please try to explain to me how this change matches: Send keep alive requests to ensure Kudu scanner does not time out?
There was a problem hiding this comment.
Sending keep alive requests is implemted in KuduScannerIterator.
/**
* An iterator for the RowResults of a KuduScanner.
* Exhausting this iterator means that all of the rows from a KuduScanner have been read.
*
* This iterator also handles sending keep alive requests to ensure the scanner
* does not time out.
*/
@InterfaceAudience.Public
@InterfaceStability.Evolving
public class KuduScannerIterator implements Iterator<RowResult> {
Praveen2112
reviewed
Nov 15, 2021
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduRecordCursor.java
Show resolved
Hide resolved
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduRecordCursor.java
Outdated
Show resolved
Hide resolved
Praveen2112
approved these changes
Nov 17, 2021
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduRecordCursor.java
Show resolved
Hide resolved
plugin/trino-kudu/src/main/java/io/trino/plugin/kudu/KuduRecordCursor.java
Show resolved
Hide resolved
KuduScannerIterator sends keep alive requests to ensure Kudu scanner does not time out
|
Merged. Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to fix #7250