Use Classloader safe implementation of RecordSetProvider for Phoenix #9942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Nov 11, 2021
testing/trino-product-tests/src/main/java/io/trino/tests/product/phoenix/TestPhoenix.java
Outdated
Show resolved
Hide resolved
...cher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodePhoenix5.java
Outdated
Show resolved
Hide resolved
...cher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodePhoenix5.java
Outdated
Show resolved
Hide resolved
| import static org.testcontainers.utility.MountableFile.forHostPath; | ||
|
|
||
| @TestsEnvironment | ||
| public final class EnvMultinodePhoenix5 |
There was a problem hiding this comment.
It looks like a copy paste of EnvMultinodePhoenix4, can you please try to extract common EnvironmentExtender
There was a problem hiding this comment.
Please don't use inheritance. Use EnvironmentExtender and org.testcontainers.containers.GenericContainer#setDockerImageName. By default you can use 5 and in one environment you can update it to 4.
There was a problem hiding this comment.
Have applied the comments.
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
from
c96e383 to
461d59e
Compare
|
@kokosing AC |
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
3 times, most recently
from
b3c7708 to
d74e95d
Compare
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
from
d74e95d to
46e521b
Compare
|
@kokosing PTAL. |
kokosing
reviewed
Nov 17, 2021
...cher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodePhoenix5.java
Outdated
Show resolved
Hide resolved
| public void testCreateTableAsSelect() | ||
| { | ||
| String tableName = "phoenix.default.nation"; | ||
| QueryResult result = onTrino().executeQuery(format("CREATE TABLE %s AS SELECT * FROM tpch.tiny.nation", tableName)); |
There was a problem hiding this comment.
Can we use some generic set of tests? Where you could set schema and catalog in tempto-configration.yaml.
There was a problem hiding this comment.
I have partially applied this comment.
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
from
46e521b to
a45ae7b
Compare
kokosing
approved these changes
Nov 18, 2021
...product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/common/Phoenix.java
Outdated
Show resolved
Hide resolved
...cher/src/main/java/io/trino/tests/product/launcher/env/environment/EnvMultinodePhoenix4.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
from
a45ae7b to
578a560
Compare
Praveen2112
force-pushed
the
praveen/phoenix_classloader_issue
branch
from
578a560 to
f7bcb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9151