Speed up translation of IN / NOT IN to tuple domain #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
martint,
losipiuk,
raunaqmorarka,
sopel39 and
kasiafi
martint
reviewed
Nov 4, 2021
core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/speed-up-translation-of-in-not-in-to-tuple-domain-b83255
branch
from
5f4b548 to
5bff879
Compare
Also, use shorter way to define list with null.
Replace it with a helper. `TupleDomain.withColumnDomains` is named in a way so that it should not be imported statically.
Among others, this adds test coverage for IN, NOT IN with floating point types, which have special treatment in `DomainTranslator`.
findepi
force-pushed
the
findepi/speed-up-translation-of-in-not-in-to-tuple-domain-b83255
branch
from
5bff879 to
0160bb2
Compare
martint
reviewed
Nov 5, 2021
| List<Expression> excludedExpressions = new ArrayList<>(); | ||
|
|
||
| for (Expression expression : valueList.getValues()) { | ||
| Object value = new ExpressionInterpreter(expression, metadata, session, expressionTypes) |
There was a problem hiding this comment.
This should normally be handled by other optimizers. Why is it necessary to do it here?
There was a problem hiding this comment.
It's necessary to obtain the native value from a constant expression.
optimization is others' responsibility, but we need to handle whatever LiteralEncoder constructs, for a type.
(btw we use this pattern in other places, for same reason.)
This makes `TestHiveConnectorTest.testLargeIn[5000]` over 3x faster.
findepi
force-pushed
the
findepi/speed-up-translation-of-in-not-in-to-tuple-domain-b83255
branch
from
0160bb2 to
25bc059
Compare
findepi
commented
Nov 5, 2021
Comment on lines
+901
to
+905
| // TODO this currently fails; fix https://github.com/trinodb/trino/issues/9885 and restore: assertThat(query("SELECT price, vendor FROM " + JSON_TABLE + " WHERE price NOT IN (4.5, 5.5, 6.5, 7.5, 8.5, 9.5)")).isNotFullyPushedDown(FilterNode.class); | ||
| assertThatThrownBy(() -> query("SELECT price, vendor FROM " + JSON_TABLE + " WHERE price NOT IN (4.5, 5.5, 6.5, 7.5, 8.5, 9.5)")) | ||
| .hasMessage("java.lang.IllegalStateException") | ||
| .hasStackTraceContaining("at com.google.common.base.Preconditions.checkState") | ||
| .hasStackTraceContaining("at io.trino.plugin.pinot.query.PinotQueryBuilder.toPredicate"); |
losipiuk
approved these changes
Nov 8, 2021
findepi
deleted the
findepi/speed-up-translation-of-in-not-in-to-tuple-domain-b83255
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
TestHiveConnectorTest.testLargeIn[5000]over 3x faster.