Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ALTER TABLE EXECUTE commands #9682

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Oct 18, 2021

Add documentation for the ALTER TABLE <name> EXECUTE <cmd> WITH <parameters> statement, starting with OPTIMIZE but laying groundwork for additional commands.

modifies the table according to the specified command and parameters. ``ALTER
TABLE EXECUTE`` supports the following commands:

* ``OPTIMIZE``: collapse files in transactional tables up to a threshold
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part about OPTIMIZE should go to Hive documentation.
The alter-table page should just note that there is mechanism to execute table procedures/commands (nomenclature to be defined); and that different procedures are provided by different connectors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and changed. Will any other connectors support EXECUTE OPTIMIZE or any other commands on 364?

@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 6874f58 to b0735e2 Compare October 19, 2021 13:35
@jhlodin jhlodin added the docs label Oct 19, 2021
docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/alter-table.rst Outdated Show resolved Hide resolved
@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from b0735e2 to 924584b Compare October 19, 2021 16:25
Copy link
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losipiuk
Copy link
Member

I added changes to adjust PR to syntax change.

@losipiuk
Copy link
Member

I also added a safety note. Please make it more English @jhlodin :)

@losipiuk
Copy link
Member

cc: @findepi

@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 27cc471 to 22ad6d4 Compare October 26, 2021 15:43
@jhlodin
Copy link
Contributor Author

jhlodin commented Oct 26, 2021

@losipiuk @findepi Edited your note a bit, PTAL and make sure I didn't make it inaccurate. If it looks good, would be great to get this squashed+merged soon so it's in before 364 is cut.

docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 22ad6d4 to 7a4ed33 Compare October 26, 2021 19:43
docs/src/main/sphinx/sql/alter-table.rst Outdated Show resolved Hide resolved
@losipiuk losipiuk merged commit 4152a0f into trinodb:master Oct 28, 2021
@github-actions github-actions bot added this to the 364 milestone Oct 28, 2021
@jhlodin jhlodin deleted the jl/alter-table-cmd branch October 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants