Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict insert overwrite to autocommit #9675

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Restrict insert overwrite to autocommit #9675

merged 2 commits into from
Oct 22, 2021

Conversation

aczajkowski
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 18, 2021
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from 79290bf to 0b34f4e Compare October 18, 2021 12:05
@aczajkowski aczajkowski mentioned this pull request Oct 18, 2021
Closed
losipiuk
losipiuk reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/trino-spi/src/main/java/io/trino/spi/predicate/ToStringSession.java Outdated Show resolved Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorSession.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/testing/TestingConnectorSession.java Outdated Show resolved Hide resolved
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from 0b34f4e to e55f40e Compare October 18, 2021 13:26
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from e55f40e to bb97839 Compare October 18, 2021 16:49
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from bb97839 to 2a61fa1 Compare October 19, 2021 13:04
@aczajkowski aczajkowski requested a review from findepi October 19, 2021 13:45
@aczajkowski aczajkowski mentioned this pull request Oct 19, 2021
Closed
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from 2a61fa1 to e7258de Compare October 19, 2021 13:51
@aczajkowski aczajkowski requested a review from findepi October 20, 2021 08:43
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch 2 times, most recently from 25a1f22 to e59f75a Compare October 20, 2021 10:23
@aczajkowski
Copy link
Member Author

@losipiuk @findepi Seems we are close to getting in aligned with all comments / ideas. Please let me know if there is anything more i can do here.

losipiuk
losipiuk reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there. Some (possibly dumb) questions.

@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from e59f75a to 4b87562 Compare October 21, 2021 16:42
@aczajkowski aczajkowski requested a review from losipiuk October 21, 2021 16:45
@losipiuk
Copy link
Member

does not compile in current shape

@aczajkowski
Copy link
Member Author

aczajkowski commented Oct 21, 2021 •
edited
Loading

does not compile in current shape

@losipiuk no idea how it happened. Ive compiled whole project locally :( .
Fixed now.

@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from 4b87562 to d4bb8c5 Compare October 21, 2021 19:29
@aczajkowski aczajkowski force-pushed the acz/restrict_insert_overwrite_to_autocommit_connector_session branch from cd8899e to e58a15f Compare October 22, 2021 10:24
@aczajkowski aczajkowski requested a review from losipiuk October 22, 2021 10:30
losipiuk
losipiuk approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@findepi wanna take another look?

@findepi
Copy link
Member

findepi commented Oct 22, 2021

skimmed, lgtm, thanks @losipiuk @aczajkowski

@losipiuk losipiuk merged commit efcef56 into trinodb:master Oct 22, 2021
@github-actions github-actions bot added this to the 364 milestone Oct 22, 2021
@aczajkowski aczajkowski mentioned this pull request Oct 23, 2021
Closed
12 tasks
@aczajkowski aczajkowski deleted the acz/restrict_insert_overwrite_to_autocommit_connector_session branch November 10, 2021 18:08
@findepi findepi mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed
Milestone
364
Development

Successfully merging this pull request may close these issues.
4 participants
@aczajkowski @losipiuk @findepi @Praveen2112