Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement contains function for IP address (continuation) #9654

Closed
wants to merge 12 commits into from
Closed

Implement contains function for IP address (continuation) #9654

wants to merge 12 commits into from

Conversation

pellicano
Copy link
Member

Developed by: @ebyhr
Contributed by: @pellicano

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@ckdarby ckdarby mentioned this pull request Oct 15, 2021
Closed
@pellicano
Copy link
Member Author

@martint signed CLA has been sent through my BlueCat's e-mail.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

@martint martint self-requested a review October 15, 2021 17:48
@pellicano
Fix pipeline errors/failures
835c856 
Fix tests. Fix code style (Airlift). Move to trino packages.
@pellicano
Merge branch 'pr/110v2'
c0d3c2a
@cla-bot cla-bot bot added the cla-signed label Oct 25, 2021
@pellicano
Copy link
Member Author

@martint apparently all checks have passed. May you take a look, please?

martint
martint requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash all the commits?

core/trino-main/src/main/java/io/trino/operator/scalar/IpAddressFunctions.java Show resolved Hide resolved
docs/src/main/sphinx/functions/ipaddress.rst Show resolved Hide resolved
@pellicano
Copy link
Member Author

@martint commits squashed into 9e6d202.

@martint
Copy link
Member

martint commented Nov 8, 2021

Merged as 4ca945f. Thanks!

@martint martint closed this Nov 8, 2021
@martint martint mentioned this pull request Nov 8, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint requested changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pellicano @martint @ebyhr