Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ALTER TABLE SET PROPERTIES statement #9401

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Add ALTER TABLE SET PROPERTIES statement #9401

merged 3 commits into from
Oct 14, 2021

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 27, 2021

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2021
@findepi
Copy link
Member

findepi commented Sep 27, 2021 •
edited
Loading

Some properties are easy to change (e.g. format in case of Hive partitioned table).
In some cases, a property change is possible, but would require some computations (e.g. format in case of Hive unpartitioned table).

I wonder whether we should integrate this statement with ALTER TABLE .. EXECUTE work @ #9398 / #9466 cc @losipiuk

kokosing
kokosing reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/server/QueryExecutionFactoryModule.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/testing/TestingAccessControlManager.java Show resolved Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java Show resolved Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java Show resolved Hide resolved
@ebyhr ebyhr force-pushed the ebi/alter-table-properties branch 5 times, most recently from 935c407 to c5dcb74 Compare October 4, 2021 06:04
@ebyhr ebyhr marked this pull request as ready for review October 4, 2021 06:04
@ebyhr ebyhr requested a review from sopel39 October 4, 2021 06:05
@losipiuk
Copy link
Member

losipiuk commented Oct 4, 2021

Some properties are easy to change (e.g. format in case of Hive partitioned table). In some cases, a property change is possible, but would require some computations (e.g. format in case of Hive unpartitioned table).

I wonder whether we should integrate this statement with ALTER TABLE .. EXECUTE work @ #9398 / #9466 cc @losipiuk

Eventually we may want to decide to share execution logic for such. But I would start with low hanging fruits, and just support "simple" properties in ALTER TABLE SET PROPERTIES so we are not overthinking too much and slow things down.

@ebyhr ebyhr force-pushed the ebi/alter-table-properties branch 2 times, most recently from 729ecee to 658f2f5 Compare October 8, 2021 01:09
sopel39
sopel39 reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/metadata/AbstractPropertyManager.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java Outdated Show resolved Hide resolved
core/trino-parser/src/main/java/io/trino/sql/SqlFormatter.java Outdated Show resolved Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java Show resolved Hide resolved
...toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java Outdated Show resolved Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/SqlStandardAccessControl.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/FeaturesConfig.java Outdated Show resolved Hide resolved
@ebyhr ebyhr force-pushed the ebi/alter-table-properties branch 2 times, most recently from 4a03c7f to 0800d4f Compare October 12, 2021 02:20
@ebyhr ebyhr requested a review from sopel39 October 12, 2021 06:32
sopel39
sopel39 reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java Outdated Show resolved Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java Outdated Show resolved Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/FeaturesConfig.java Outdated Show resolved Hide resolved
core/trino-main/src/test/java/io/trino/connector/MockConnector.java Outdated Show resolved Hide resolved
@ebyhr
Copy link
Member Author

ebyhr commented Oct 13, 2021

CI #8691 and #9612

@ebyhr
Copy link
Member Author

ebyhr commented Oct 13, 2021

@sopel39 Applied comments.

@sopel39 sopel39 mentioned this pull request Oct 13, 2021
Merged
@ebyhr ebyhr force-pushed the ebi/alter-table-properties branch from 4e1693b to cf368de Compare October 13, 2021 13:38
@ebyhr ebyhr merged commit a50f16e into trinodb:master Oct 14, 2021
@ebyhr ebyhr deleted the ebi/alter-table-properties branch October 14, 2021 00:52
@github-actions github-actions bot added this to the 364 milestone Oct 14, 2021
@ebyhr ebyhr mentioned this pull request Oct 14, 2021
Closed
12 tasks
@findepi findepi mentioned this pull request Feb 3, 2022
Merged
@pratyakshsharma pratyakshsharma mentioned this pull request Dec 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing left review comments

@sopel39 sopel39 sopel39 approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
364
Development

Successfully merging this pull request may close these issues.
5 participants
@ebyhr @findepi @losipiuk @sopel39 @kokosing