Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in TestMemoryConnectorTest #9055

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Fix flakiness in TestMemoryConnectorTest #9055

merged 3 commits into from
Aug 31, 2021

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Aug 31, 2021

AbstractTestDistributedQueries already runs testCreateTable which
creates a table, drops it and then asserts that the table is indeed
dropped.

See

trino/testing/trino-testing/src/main/java/io/trino/testing/AbstractTestDistributedQueries.java

Lines 145 to 150 in 6f1297f

assertUpdate("CREATE TABLE " + tableName + " (a bigint, b double, c varchar(50))");
assertTrue(getQueryRunner().tableExists(getSession(), tableName));
assertTableColumnNames(tableName, "a", "b", "c");
assertUpdate("DROP TABLE " + tableName);
assertFalse(getQueryRunner().tableExists(getSession(), tableName));
for the existing coverage.

Fixes #9051

@hashhar
Remove obsolete test
f7f261f 
AbstractTestDistributedQueries already runs testCreateTable which
creates a table, drops it and then asserts that the table is indeed
dropped.
@hashhar hashhar requested review from findepi and ebyhr August 31, 2021 07:17
@cla-bot cla-bot bot added the cla-signed label Aug 31, 2021
@hashhar hashhar changed the title Remove obsolete flaky test Fix flakiness in TestMemoryConnectorTest Aug 31, 2021
@hashhar
Change assertions to explicitly check for existence of table
b5bd364 
Counting number of tables leads to flakiness in case of parallel test
execution.
@hashhar hashhar force-pushed the hashhar/memory-flaky branch from 8d81361 to b5bd364 Compare August 31, 2021 08:10
ebyhr
ebyhr approved these changes Aug 31, 2021
View reviewed changes
plugin/trino-memory/src/test/java/io/trino/plugin/memory/TestMemoryConnectorTest.java Outdated
@@ -117,17 +117,6 @@ protected TestTable createTableWithDefaultColumns()
throw new SkipException("Cassandra connector does not support column default values");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix this line in a new commit or PR? > "Cassandra"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Adding another commit.

@hashhar
Copy link
Member Author

hashhar commented Aug 31, 2021

CI hit #8917.

@hashhar hashhar merged commit ab46771 into trinodb:master Aug 31, 2021
@hashhar hashhar added this to the 362 milestone Aug 31, 2021
@hashhar hashhar deleted the hashhar/memory-flaky branch August 31, 2021 11:51
@findepi findepi added the test label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

@ebyhr ebyhr ebyhr approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees
No one assigned
Labels
cla-signed test
Milestone
362
Development

Successfully merging this pull request may close these issues.

Flaky io.trino.plugin.memory.TestMemoryConnectorTest.testCreateAndDropTable
4 participants
@hashhar @ebyhr @kokosing @findepi