Remove TableLayout from Elasticsearch connector #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
es_table_layout_removal
branch
from
478f845 to
d14e876
Compare
Praveen2112
force-pushed
the
es_table_layout_removal
branch
from
d14e876 to
f083269
Compare
16 tasks
martint
requested changes
Jun 4, 2019
| group.getShardId().getId(), | ||
| nodes[nodeIndex].getHostName(), | ||
| nodes[nodeIndex].getAddress().getPort(), | ||
| layoutHandle.getTupleDomain()); | ||
| tableHandle.getConstraint()); |
There was a problem hiding this comment.
The table handle is now available in getRecordSet, so we should be able to create the recordset directly with the constraint extracted from the handle instead of passing it via the splits.
Praveen2112
force-pushed
the
es_table_layout_removal
branch
from
f083269 to
afbab2d
Compare
Praveen2112
force-pushed
the
es_table_layout_removal
branch
from
afbab2d to
aa5667f
Compare
martint
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the TableLayout for Elasticsearch connector. (#781)