Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Iceberg value strictly #8746

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Convert to Iceberg value strictly #8746

merged 3 commits into from
Aug 3, 2021

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 2, 2021

No description provided.

@findepi findepi force-pushed the findepi/small-refac branch from a465072 to 88b8ccd Compare August 2, 2021 10:51
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2021
@findepi findepi added the maintenance Project maintenance task label Aug 2, 2021
hashhar
hashhar approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a TODO+issue for the UnsupportedOperationException from toIcebergExpression for structural types.

@findepi
Copy link
Member Author

findepi commented Aug 3, 2021

TODO+issue for the UnsupportedOperationException from toIcebergExpression for structural types.

#8759

findepi added 3 commits August 3, 2021 12:39
@findepi
Convert to Iceberg value strictly
1aad472
@findepi
Rename varchar/varbinary Parquet writer
370ffcb 
Before the change, it was not intuitive that `CharValueWriter` is
suitable for `varbinary` data.  The new name better describes what the
writer is doing, and that it doesn't assume slice's contents to
represent characters.
@findepi
Correct type used to get varbinary value
2b92924
@findepi findepi force-pushed the findepi/small-refac branch from 88b8ccd to 2b92924 Compare August 3, 2021 10:39
@findepi findepi merged commit 89b40ce into trinodb:master Aug 3, 2021
@findepi findepi deleted the findepi/small-refac branch August 3, 2021 10:39
@findepi findepi added this to the 361 milestone Aug 3, 2021
@alexjo2144
Copy link
Member

The strictness changes in ExpressonConverter broke queries with certain type filters. I think this needed to go along with a change in applyFilter to exclude row/array/map type predicates from the table's unenforced constraint.

@alexjo2144 alexjo2144 mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@electrum electrum Awaiting requested review from electrum

@sopel39 sopel39 Awaiting requested review from sopel39

@phd3 phd3 Awaiting requested review from phd3

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed maintenance Project maintenance task
Milestone
361
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @alexjo2144 @hashhar