Remove Flaky annotation on tests expected to work #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause was fixed in trinodb#8504.
|
You can stress-test this like https://github.com/trinodb/trino/pull/7593/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR26-R28 to make sure it's not Flaky anymore. |
|
#4864 shows an additional warning given by iceberg finalizer code that contains the stacktrace to indicate the codepath that creates streams that weren't explicitly closed. I've also seen the same while debugging #5201, but somehow not added on the issue. I think it should be safe to get this in, since #8504 was stress-tested. |
|
@hashhar thumbed up, so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4864 seems like a duplicate of #5201.