Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict dropping non-empty schema #8660

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Restrict dropping non-empty schema #8660

merged 2 commits into from
Jul 27, 2021

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jul 26, 2021

No description provided.

@wendigo wendigo requested review from findepi and hashhar July 26, 2021 09:40
@wendigo wendigo force-pushed the serafin/drop-schema-validation branch from ec03a00 to a8d0945 Compare July 26, 2021 10:19
@cla-bot cla-bot bot added the cla-signed label Jul 26, 2021
@wendigo wendigo requested a review from kokosing July 26, 2021 12:17
@wendigo wendigo force-pushed the serafin/drop-schema-validation branch 2 times, most recently from b70abdc to 0c99616 Compare July 26, 2021 12:34
@wendigo wendigo force-pushed the serafin/drop-schema-validation branch from 0c99616 to 0dd8a15 Compare July 26, 2021 19:59
@wendigo wendigo force-pushed the serafin/drop-schema-validation branch from 0dd8a15 to d7c0bd6 Compare July 27, 2021 09:29
hashhar
hashhar reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

testing/trino-testing/src/main/java/io/trino/testing/AbstractTestDistributedQueries.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java Show resolved Hide resolved
wendigo added 2 commits July 27, 2021 13:31
@wendigo
Test if random schema name could be created
51a7bd4 
Do not test whether existing schema can be dropped as new condition
in the following commit won't allow dropping non-empty schema.
@wendigo
Restrict dropping non-empty schema
9f888c5
@wendigo wendigo force-pushed the serafin/drop-schema-validation branch from d7c0bd6 to 9f888c5 Compare July 27, 2021 11:31
hashhar
hashhar approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

@hashhar hashhar merged commit 38f6aef into trinodb:master Jul 27, 2021
@hashhar hashhar added this to the 360 milestone Jul 27, 2021
@wendigo wendigo deleted the serafin/drop-schema-validation branch July 27, 2021 12:42
@wendigo wendigo mentioned this pull request Jul 27, 2021
Closed
@hashhar hashhar mentioned this pull request Jul 27, 2021
Closed
11 tasks
@ebyhr ebyhr mentioned this pull request Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi left review comments

@kokosing kokosing kokosing approved these changes

@hashhar hashhar hashhar approved these changes

Assignees

@hashhar hashhar

Labels
cla-signed
Milestone
360
Development

Successfully merging this pull request may close these issues.
4 participants
@wendigo @findepi @kokosing @hashhar