Improve positionsArrayToSelectedPositions #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sopel39
commented
Jul 21, 2021
•
sopel39
commented
sopel39
force-pushed
the
ks/improve_sel_pos
branch
from
96e7599 to
a7f1138
Compare
skrzypo987
approved these changes
Jul 21, 2021
raunaqmorarka
approved these changes
Jul 21, 2021
findepi
approved these changes
Jul 21, 2021
* Use boolean casting instead of if to avoid branching * Finish loop early when there are no more selected positions
sopel39
force-pushed
the
ks/improve_sel_pos
branch
from
a7f1138 to
d9ae784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.