Simplify PartitionedOutputOperator #8437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettyjamesm
force-pushed
the
improve-partitioned-output-operator
branch
3 times, most recently
from
35abcb3 to
ebfa1bd
Compare
martint
approved these changes
Jul 7, 2021
core/trino-main/src/main/java/io/trino/operator/PartitionedOutputOperator.java
Outdated
Show resolved
Hide resolved
pettyjamesm
force-pushed
the
improve-partitioned-output-operator
branch
from
ebfa1bd to
a7e931d
Compare
Hoists "any row" replication and nullBlock.isNull logic out of the PartitionedOutputOperator.PagePartitioner inner loop logic
pettyjamesm
force-pushed
the
improve-partitioned-output-operator
branch
from
a7e931d to
8e02194
Compare
|
Test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies
PartitionedOutputOperatorlogic in the inner loop by hoisting "any row" replication outside of it and checkingBlock#mayHaveNull()before querying the null channel on each iteration.Also adds
mayHaveNull()implementations toDictionaryBlock,RunLengthEncodedBlock, andGroupByIdBlockwithout which that hoisted checking would be less effective.This change also includes a fix for
PartitionedOutputOperator#close()not callingsystemMemoryContext#close()(memory was still being released byOperatorContext#destroy()but would use the "force free" allocation tag, resulting in incorrect query OOM top consumer reporting).