Minor JDBC Connector tests fixes #8361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
requested review from
findepi,
wendigo and
Praveen2112
and removed request for
findepi
|
Extracted from #6287 |
findepi
approved these changes
Jun 23, 2021
Praveen2112
approved these changes
Jun 23, 2021
|
Thanks for the review, I have just added two more commits. |
kokosing
force-pushed
the
origin/master/285_minor_jdbc_fixes
branch
2 times, most recently
from
cc39a50 to
ced3f14
Compare
By default SUPPORTS_CREATE_VIEW and SUPPORTS_DELETE are set to false. No need to repeat that in BaseJdbcConnectorTest.
- Remove obsolete comment - regionkey starts from 0, so fix expected results
This method requires to be implemented so it is part of the contract, hence it should be visible more.
kokosing
force-pushed
the
origin/master/285_minor_jdbc_fixes
branch
from
ced3f14 to
e2ff459
Compare
findepi
reviewed
Jun 24, 2021
| @@ -87,6 +87,8 @@ | |||
| { | |||
| private final ExecutorService executor = newCachedThreadPool(daemonThreadsNamed(getClass().getName())); | |||
|
|
|||
| protected abstract SqlExecutor onRemoteDatabase(); | |||
There was a problem hiding this comment.
OTOH it's a helper, so i belongs at the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.