Populate the test data in a single query #8301
Conversation
Praveen2112
requested review from
findepi,
losipiuk,
ksobolew and
lukasz-walkiewicz
...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveTransactionalTable.java
Show resolved
Hide resolved
| @@ -1401,8 +1401,7 @@ public void testAcidUpdateWithSubqueryAssignment() | |||
| // TODO support UPDATE with correlated subquery in assignment | |||
| withTemporaryTable("test_update_subquery", true, false, NONE, tableName -> { | |||
| onTrino().executeQuery(format("CREATE TABLE %s (column1 INT, column2 varchar) WITH (transactional = true)", tableName)); | |||
| onTrino().executeQuery(format("INSERT INTO %s VALUES (1, 'x')", tableName)); | |||
| onTrino().executeQuery(format("INSERT INTO %s VALUES (2, 'y')", tableName)); | |||
| onTrino().executeQuery(format("INSERT INTO %s VALUES (1, 'x'), (2, 'y')", tableName)); | |||
There was a problem hiding this comment.
@Praveen2112 do you understand why INSERT-ing two rows at once avoids #8268 while two separate INSERTs followed up UPDATEs lead to a failure on Hive side?
There was a problem hiding this comment.
Still investigating on why it works.
There was a problem hiding this comment.
I think this is why it works - #8268 (comment)
There was a problem hiding this comment.
When we run the inserts in a same query - single delta file is created and delete information are properly mapped to the file (since they have different rowId) thus it works.
@Praveen2112 remove this from the |
Praveen2112
force-pushed
the
praveen/081/hive_fix_3
branch
from
0842809 to
059993a
Compare
This fixes error when reading table from Hive. Ref: https://issues.apache.org/jira/browse/HIVE-22318
Praveen2112
force-pushed
the
praveen/081/hive_fix_3
branch
from
059993a to
abb35e8
Compare
|
@findepi AC. Please let me know if there is any issues. |
No description provided.