Remove TableLayout from Accumulo connector #823
Conversation
Praveen2112
force-pushed
the
accumulo_table_layout_removal
branch
from
bdff503 to
f023b4e
Compare
| handle.getTable(), | ||
| handle.getRowId(), | ||
| newDomain, | ||
| getColumnConstraints(handle.getRowId(), newDomain), |
There was a problem hiding this comment.
Why do we need to hold on to the column constraints in the table handle? It seems like we should be able to do this directly where they are needed (i.e., in getSplits)
There was a problem hiding this comment.
Column constraints are also similar to TupleDomain which would remain same for all splits so thought of moving it to the AccumuloTableHandle.
There was a problem hiding this comment.
As far as I can tell, they are only used in getSplits() to call client.getTabletSplits(...), but they are not stored in splits. So we could derive them directly in getSplits() from the information in the handle.
There was a problem hiding this comment.
It was passed to AccumuloRecordSet and AccumuloRecordCursor but it is not used anywhere expect in getting the split metadata. So we can maintain it as TupleDomain and derive it from table handle.
Praveen2112
force-pushed
the
accumulo_table_layout_removal
branch
from
f023b4e to
6b38abc
Compare
Praveen2112
force-pushed
the
accumulo_table_layout_removal
branch
from
6b38abc to
f86bcb7
Compare
|
@martint Have removed the column constraint from the table handle. Please let me know if there is any more changes. |
Removes the TableLayout for Accumulo connector. (#781)