Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow use of implicit types in remote databases in type tests #7245

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Disallow use of implicit types in remote databases in type tests #7245

merged 2 commits into from
Mar 11, 2021

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 10, 2021

Follow up to #7166 (comment)

@cla-bot cla-bot bot added the cla-signed label Mar 10, 2021
@findepi findepi mentioned this pull request Mar 10, 2021
Merged
@findepi findepi force-pushed the findepi/enforce-explicit-types branch from c0c82c6 to e4676f4 Compare March 10, 2021 21:56
@findepi findepi added maintenance Project maintenance task test labels Mar 10, 2021
@findepi findepi force-pushed the findepi/enforce-explicit-types branch 2 times, most recently from 2a7ad29 to 6931b24 Compare March 10, 2021 22:25
jirassimok
jirassimok approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@jirassimok jirassimok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That last push addressed my only big comment before I finished writing it; very nice.

Looks good; just a grammar fix and two small suggestions.

plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/datatype/CreateAndInsertDataSetup.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/datatype/CreateAndInsertDataSetup.java Outdated Show resolved Hide resolved
hashhar
hashhar approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@findepi findepi force-pushed the findepi/enforce-explicit-types branch from 6931b24 to 203696b Compare March 11, 2021 08:48
@findepi
Copy link
Member Author

findepi commented Mar 11, 2021

AC, changed comment & message

jirassimok
jirassimok approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@jirassimok jirassimok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice improvement.

@findepi findepi merged commit 3f794dc into trinodb:master Mar 11, 2021
@findepi findepi deleted the findepi/enforce-explicit-types branch March 11, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirassimok jirassimok jirassimok approved these changes

@hashhar hashhar hashhar approved these changes

@sopel39 sopel39 sopel39 approved these changes

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees
No one assigned
Labels
cla-signed maintenance Project maintenance task test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @sopel39 @hashhar @jirassimok