Run JDBC connector tests with H2 in single thread #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
approved these changes
Mar 8, 2021
|
Do you happen to know how much does it add to test runtime? |
kokosing
approved these changes
Mar 8, 2021
i do not |
H2 is quite fast. We run tests in 2 threads IIRC and we have to tests classes so there is an overlap still. It should not affect much. |
H2 DDL operations can sometimes take a global lock, leading to apparent deadlocks.
findepi
force-pushed
the
findepi/run-jdbc-connector-tests-with-h2-in-single-thread-70358c
branch
from
ecec7d0 to
d4fdb4e
Compare
findepi
deleted the
findepi/run-jdbc-connector-tests-with-h2-in-single-thread-70358c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H2 DDL operations can sometimes take a global lock, leading to apparent
deadlocks.
Fixes #7209